Fix build for ext-proc example #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Tang <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
kfswain
approved these changes
Sep 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shaneutt
pushed a commit
to shaneutt/gateway-api-inference-extension
that referenced
this pull request
Apr 18, 2025
- CONTAINER_TOOL setting commented out until can be fixed correctly (Ref kubernetes-sigs#7) - image name was missing `epp` as last element in tag Signed-off-by: Etai Lev Ran <[email protected]>
vMaroon
pushed a commit
to mayabar/gateway-api-inference-extension
that referenced
this pull request
Apr 23, 2025
- CONTAINER_TOOL setting commented out until can be fixed correctly (Ref kubernetes-sigs#7) - image name was missing `epp` as last element in tag Signed-off-by: Etai Lev Ran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following issues when building the binary: